Paths

Table of Contentst

Differential D19577

Add a modern "user.edit" API method for users
ClosedPublic
Actions

Authored by epriestley on Aug 13 2018, 10:10 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rP65904d7c5137: Add a modern "user.edit" API method for users

Summary

Depends on D19576. Ref T13164. See PHI642. This adds an EditEngine for users and a user.edit modern API method.

For now, all it supports is editing real name, blurb, title, and icon (same as "Edit Profile" from the UI).

Test Plan

Edited my stuff via the new API method.
Tried to edit another user, got rejected by policies.
Tried to create a user, got rejected by policies.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 13 2018, 10:10 PM

Harbormaster completed remote builds in B20605: Diff 46804.Aug 13 2018, 10:11 PM

epriestley requested review of this revision.Aug 13 2018, 10:11 PM

epriestley added a child revision: D19579: Allow "user.edit" to enable or disable users.Aug 13 2018, 10:40 PM

amckinley accepted this revision.Aug 13 2018, 10:47 PM

This revision is now accepted and ready to land.Aug 13 2018, 10:47 PM

Closed by commit rP65904d7c5137: Add a modern "user.edit" API method for users (authored by epriestley). · Explain WhyAug 16 2018, 5:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

people/

conduit/

UserEditConduitAPIMethod.php

20 lines

customfield/

PhabricatorUserBlurbField.php

21 lines

PhabricatorUserIconField.php

21 lines

PhabricatorUserRealNameField.php

21 lines

PhabricatorUserTitleField.php

21 lines

editor/

PhabricatorUserEditEngine.php

70 lines

Diff 46833

View Options

src/__phutil_library_map__.php

View Options

src/applications/people/conduit/UserEditConduitAPIMethod.php

View Options

src/applications/people/customfield/PhabricatorUserBlurbField.php

View Options

src/applications/people/customfield/PhabricatorUserIconField.php

View Options

src/applications/people/customfield/PhabricatorUserRealNameField.php

View Options

src/applications/people/customfield/PhabricatorUserTitleField.php

View Options

src/applications/people/editor/PhabricatorUserEditEngine.php

Add a modern "user.edit" API method for usersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46833

src/__phutil_library_map__.php

src/applications/people/conduit/UserEditConduitAPIMethod.php

src/applications/people/customfield/PhabricatorUserBlurbField.php

src/applications/people/customfield/PhabricatorUserIconField.php

src/applications/people/customfield/PhabricatorUserRealNameField.php

src/applications/people/customfield/PhabricatorUserTitleField.php

src/applications/people/editor/PhabricatorUserEditEngine.php

Add a modern "user.edit" API method for users
ClosedPublic
Actions

Revision Contents
Changeset List