Page MenuHomePhabricator
Differential D19582

Remove pointless requireCapabilities() method from PhabricatorProjectColumnTransactionEditor
ClosedPublic
Actions

Authored by epriestley on Aug 14 2018, 8:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:01 AM
Unknown Object (File)
Fri, Apr 19, 7:51 PM
Unknown Object (File)
Thu, Apr 18, 11:44 AM
Unknown Object (File)
Wed, Apr 17, 6:32 PM
Unknown Object (File)
Mon, Apr 15, 4:32 PM
Unknown Object (File)
Thu, Apr 11, 3:52 PM
Unknown Object (File)
Thu, Apr 11, 3:52 PM
Unknown Object (File)
Thu, Apr 11, 3:51 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13164: Plans: 2018 Week 31 - 33 Bonus Content
Commits
rPa39852ae1b4a: Remove pointless requireCapabilities() method from…
Summary

Depends on D19581. Ref T13164. This method has no effect:

  • You must always have CAN_EDIT to reach an Editor in the first place.
  • Per previous change, I'm going to restructure this so transactions explicitly check CAN_EDIT by default anyway.
Test Plan

Tried to edit and hide a project column as a user without permission, hit global permission checks long before reaching this method.

Diff Detail

Repository
rP Phabricator
Branch
uxaction5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20613
Build 28008: Run Core Tests
Build 28007: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
project/
editor/
18 lines

Diff 46813

View Options

src/applications/project/editor/PhabricatorProjectColumnTransactionEditor.php

Loading...
Phabricator · Built by Phacility