Differential D19289

When a draft's builds fail and it demotes to "Changes Planned + Draft", notify the author (only) via email
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 4:56 PM.

Details

Reviewers: None
Maniphest Tasks: T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits: rP804f9817c3e2: When a draft's builds fail and it demotes to "Changes Planned + Draft", notify…

Summary

Depends on D19288. Ref T13110. In addition to kicking revisions back to "Changes Planned" when builds fail, notify the author that they need to fix their awful garbage change.

(The actual email could be more useful than it currently is.)

Test Plan

Created a revision with failing remote builds, saw email about the problem generate.

Diff Detail

Repository

rP Phabricator

Branch

bengin12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19976
Build 27087: Run Core Tests
Build 27086: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 3 2018, 4:56 PM

Harbormaster completed remote builds in B19976: Diff 46155.Apr 3 2018, 4:57 PM

epriestley requested review of this revision.Apr 3 2018, 4:57 PM

epriestley added a child revision: D19290: Clean up an old transaction state flag.Apr 3 2018, 5:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 6:11 PM

Closed by commit rP804f9817c3e2: When a draft's builds fail and it demotes to "Changes Planned + Draft", notify… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

49 lines

Diff 46155

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

When a draft's builds fail and it demotes to "Changes Planned + Draft", notify the author (only) via emailClosedPublicActions