Page MenuHomePhabricator

Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state
ClosedPublic

Authored by epriestley on Apr 3 2018, 3:47 PM.
Tags
None
Referenced Files
F19443365: D19285.id46167.diff
Mon, Dec 29, 3:38 AM
F19281734: D19285.id.diff
Tue, Dec 23, 3:49 AM
F19256274: D19285.diff
Mon, Dec 22, 1:11 PM
F19150794: D19285.diff
Dec 10 2025, 9:43 PM
F19150520: D19285.diff
Dec 10 2025, 9:20 PM
F18853086: D19285.diff
Oct 31 2025, 2:04 PM
F18763775: D19285.id46167.diff
Oct 7 2025, 2:12 AM
F18509499: D19285.id.diff
Sep 5 2025, 3:26 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19284. Ref T13110. It's now possible to get a revision into a "Abandoned + But, Never Promoted From Draft" state. Show this in the header and provide the draft hint above the comment area.

Also, remove shouldBroadcast(). The method getShouldBroadcast() now has the same meaning.

Finally, migrate existing drafts to shouldBroadcast = false and default shouldBroadcast to true. If we don't do this, every older revision becomes a non-broadcasting revision because this flag was not explicitly set on revision creation before, only on promotion out of draft.

Test Plan

Ran migration; abandoned draft revisions and ended up in a draft + abandoned state.

Diff Detail

Repository
rP Phabricator
Branch
bengine8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19972
Build 27079: Run Core Tests
Build 27078: arc lint + arc unit