Paths

Table of Contentst

Differential D19285

Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 3:47 PM.

Tags

None

Referenced Files

	F18459537: D19285.diff
	Mon, Sep 1, 5:20 PM

	F18087472: D19285.id.diff
	Wed, Aug 6, 4:08 AM

	F18084278: D19285.diff
	Tue, Aug 5, 2:37 PM

	F17781332: D19285.id.diff
	Jul 24 2025, 6:15 AM

	F17752405: D19285.diff
	Jul 22 2025, 7:02 AM

	Unknown Object (File)
	Jun 1 2025, 9:10 AM

	Unknown Object (File)
	May 30 2025, 1:13 PM

	Unknown Object (File)
	May 9 2025, 6:12 AM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits: rP615d27c8e97f: Show an additional "Draft" tag on non-broadcasting revisions in a non-draft…

Summary

Depends on D19284. Ref T13110. It's now possible to get a revision into a "Abandoned + But, Never Promoted From Draft" state. Show this in the header and provide the draft hint above the comment area.

Also, remove shouldBroadcast(). The method getShouldBroadcast() now has the same meaning.

Finally, migrate existing drafts to shouldBroadcast = false and default shouldBroadcast to true. If we don't do this, every older revision becomes a non-broadcasting revision because this flag was not explicitly set on revision creation before, only on promotion out of draft.

Test Plan

Ran migration; abandoned draft revisions and ended up in a draft + abandoned state.

Diff Detail

Repository

Branch

bengine8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19972
Build 27079: Run Core Tests
Build 27078: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 3 2018, 3:47 PM

Owners added a subscriber: Restricted Owners Package.Apr 3 2018, 3:47 PM

Harbormaster completed remote builds in B19972: Diff 46151.Apr 3 2018, 3:48 PM

epriestley requested review of this revision.Apr 3 2018, 3:48 PM

epriestley added a child revision: D19286: When a non-broadcasting revision is updated, put it in "Draft", not "Needs Review".Apr 3 2018, 3:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 6:09 PM

Closed by commit rP615d27c8e97f: Show an additional "Draft" tag on non-broadcasting revisions in a non-draft… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180403.draft.01.broadcast.php

20 lines

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

18 lines

customfield/

DifferentialDraftField.php

2 lines

editor/

DifferentialTransactionEditor.php

6 lines

storage/

DifferentialRevision.php

15 lines

Diff 46151

resources/sql/autopatches/20180403.draft.01.broadcast.php

Loading...

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...

src/applications/differential/customfield/DifferentialDraftField.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...