Page MenuHomePhabricator

Sort of make Harbormaster build logs page properly
ClosedPublic

Authored by epriestley on Feb 26 2018, 10:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 7:42 AM
Unknown Object (File)
Sat, Feb 22, 12:15 PM
Unknown Object (File)
Sun, Feb 9, 5:33 AM
Unknown Object (File)
Sun, Feb 9, 5:33 AM
Unknown Object (File)
Sun, Feb 9, 5:33 AM
Unknown Object (File)
Sun, Feb 9, 5:32 AM
Unknown Object (File)
Jan 31 2025, 12:45 AM
Unknown Object (File)
Jan 28 2025, 3:27 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19139. Ref T13088. This doesn't actually work, but is close enough that a skilled attacker might be able to briefly deceive a small child.

Test Plan
  • Viewed some very small logs under very controlled conditions, saw content.
  • Larger logs vaguely do something resembling working correctly.

Diff Detail

Repository
rP Phabricator
Branch
hlog11
Lint
Lint Warnings
Unit
Tests Passed
Build Status
Buildable 19659
Build 26623: Run Core Tests
Build 26622: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 26 2018, 10:50 PM
  • Remove no-longer-used BuildLogRange class, which may return later.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:58 AM
This revision was automatically updated to reflect the committed changes.