Paths

Table of Contentst

Differential D19141

Sort of make Harbormaster build logs page properly
ClosedPublic
Actions

Authored by epriestley on Feb 26 2018, 10:50 PM.

Tags

None

Referenced Files

	F15480526: D19141.diff
	Tue, Apr 8, 2:43 PM

	F15475262: D19141.id45849.diff
	Sun, Apr 6, 5:52 PM

	F15474276: D19141.id45848.diff
	Sun, Apr 6, 6:56 AM

	F15472159: D19141.diff
	Sat, Apr 5, 11:09 AM

	F15462818: D19141.id45861.diff
	Tue, Apr 1, 5:56 PM

	F15432052: D19141.id45861.diff
	Mon, Mar 24, 3:57 PM

	F15416242: D19141.id45848.diff
	Thu, Mar 20, 10:00 AM

	F15409517: D19141.id45861.diff
	Wed, Mar 19, 4:38 AM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rP11d1dc484b86: Sort of make Harbormaster build logs page properly

Summary

Depends on D19139. Ref T13088. This doesn't actually work, but is close enough that a skilled attacker might be able to briefly deceive a small child.

Test Plan

Viewed some very small logs under very controlled conditions, saw content.
Larger logs vaguely do something resembling working correctly.

Diff Detail

Repository

Branch

hlog11

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/harbormaster/behavior-harbormaster-log.js:1	JAVELIN5	`javelinsymbols` Not In Path
Advice	src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php:408	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 19659
Build 26623: Run Core Tests
Build 26622: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 26 2018, 10:50 PM

Owners added a subscriber: Restricted Owners Package.Feb 26 2018, 10:50 PM

Harbormaster failed remote builds in B19659: Diff 45848!Feb 26 2018, 10:50 PM

Remove no-longer-used BuildLogRange class, which may return later.

Harbormaster failed remote builds in B19660: Diff 45849!Feb 27 2018, 12:03 AM

epriestley requested review of this revision.Feb 27 2018, 1:49 AM

epriestley added a child revision: D19142: Fix some of the most egregious errors in Harbormaster log paging.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:58 AM

Closed by commit rP11d1dc484b86: Sort of make Harbormaster build logs page properly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

9 lines

src/

__phutil_library_map__.php

4 lines

applications/

harbormaster/

application/

PhabricatorHarbormasterApplication.php

5 lines

controller/

HarbormasterBuildLogRenderController.php

562 lines

HarbormasterBuildLogViewController.php

6 lines

storage/

build/

HarbormasterBuildLog.php

33 lines

view/

HarbormasterBuildLogRange.php

46 lines

HarbormasterBuildLogView.php

30 lines

webroot/

rsrc/

css/

application/

harbormaster/

harbormaster.css

38 lines

js/

application/

harbormaster/

behavior-harbormaster-log.js

43 lines

Diff 45848

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

Loading...

src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php

Loading...

src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php

Loading...

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...

src/applications/harbormaster/view/HarbormasterBuildLogRange.php

Loading...

src/applications/harbormaster/view/HarbormasterBuildLogView.php

Loading...

webroot/rsrc/css/application/harbormaster/harbormaster.css

Loading...

webroot/rsrc/js/application/harbormaster/behavior-harbormaster-log.js

Loading...