Page MenuHomePhabricator

Store the Harbormaster log chunk format on the log record
ClosedPublic

Authored by epriestley on Feb 23 2018, 2:15 PM.
Tags
None
Referenced Files
F19071478: D19138.id.diff
Nov 30 2025, 7:40 PM
F19061030: D19138.diff
Nov 29 2025, 11:14 AM
F18968345: D19138.id45859.diff
Nov 15 2025, 1:10 AM
F18968344: D19138.id.diff
Nov 15 2025, 1:10 AM
F18968343: D19138.id45844.diff
Nov 15 2025, 1:10 AM
F18865651: D19138.id.diff
Nov 3 2025, 1:21 PM
F18813360: D19138.diff
Oct 20 2025, 3:39 PM
F18806446: D19138.id.diff
Oct 18 2025, 7:33 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19137. Ref T13088. This allows rebuild-log to skip work if the chunks are already compressed. It also prepares for a future GC which is looking for "text" or "gzip" chunks to throw away in favor of archival into Files; such a GC can use this column to find collectable logs and then write "file" to it, meaning "chunks are gone, this data is only available in Files".

Test Plan

Ran migration, saw logs populate as "text". Ran rebuild-log, saw logs rebuild as "gzip".

Diff Detail

Repository
rP Phabricator
Branch
hlog9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19653
Build 26614: Run Core Tests
Build 26613: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:56 AM
This revision was automatically updated to reflect the committed changes.