Differential D19016

Add a "View Object" button on the web mail view page
ClosedPublic
Actions

Authored by epriestley on Feb 7 2018, 12:08 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13053: Plans: Mail Tags and Failover

Commits

rP0986c7f6732e: Add a "View Object" button on the web mail view page

Summary

Depends on D19015. Ref T13053. Currently, we don't link up hyperlinks in the body of mail viewed in the web UI. We should, but this is a little tricky (see T13053#235074).

As a general improvement to make working with "Must Encrypt" mail less painful, add a big button to jump to the related object.

Test Plan

Screen Shot 2018-02-07 at 4.05.36 AM.png (634×1 px, 82 KB)

Diff Detail

Repository

rP Phabricator

Branch

mailer14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19379
Build 26208: Run Core Tests
Build 26207: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 7 2018, 12:08 PM

Harbormaster completed remote builds in B19379: Diff 45585.Feb 7 2018, 12:10 PM

epriestley requested review of this revision.Feb 7 2018, 12:10 PM

epriestley added a child revision: D19017: Support Postmark inbound mail via webhook.Feb 7 2018, 1:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 2:24 PM

Closed by commit rP0986c7f6732e: Add a "View Object" button on the web mail view page (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

controller/

PhabricatorMetaMTAMailViewController.php

20 lines

Diff 45585

View Options

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

Add a "View Object" button on the web mail view pageClosedPublicActions