Evidently I only tested adding a question, not an answer. Properly set the getter. Also, fixed some header spacing.
Details
Details
- Reviewers
epriestley avivey - Commits
- Restricted Diffusion Commit
rPbe0e84a81abc: Fix Ponder Exception, spacing
Summary
Test Plan
Add a question, add an answer. See everything work, proper spacing.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- ponder-oops (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 10836 Build 13356: Run Core Tests Build 13355: arc lint + arc unit
Event Timeline
chad updated this object.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 24 2016, 4:33 AM2016-02-24 04:33:24 (UTC+0)
chad updated this object.
avivey edited edge metadata.
This revision is now accepted and ready to land.Feb 24 2016, 4:37 AM2016-02-24 04:37:20 (UTC+0)
Closed by commit rPbe0e84a81abc: Fix Ponder Exception, spacing (authored by chad, committed by chad). · Explain WhyFeb 24 2016, 4:38 AM2016-02-24 04:38:02 (UTC+0)
This revision was automatically updated to reflect the committed changes.
• Persona added parent revisions: D15336: L10n: projects → project tags, D15335: Only hide archived project tags on workboard cards, D15338: Fix a couple of column editing issues, D15340: Correct an old issue with Paste by restoring the file attachment edge, D15334: Sort Spaces dropdown by name, not "alphabetical ID", D15326: Use EditEngine for Almanac Services, Devices, and Networks, D15308: Move Diffusion ReadmeView to PHUIDocumentProView, D15299: Disable linter rules by default if a linter standard is defined, D15300: Update import/clear symbols scripts for callsigns, D15301: Support ID-based repository URIs, and canonicalize repository URIs, D15302: Make serving repositories work with alternate URIs, D15303: Don't require a callsign to set a repository's local path, D15304: Make callsigns editable on repository basic information, D15305: Make repository callsigns optional, D15296: Make `bin/diviner generate --repository <repository>` accept identifiers, D15264: Filter out archived projects from ProjectProfileView, D15263: Put boundary spaces around crumb names so double-clicking doesn't flip out, D15265: Don't try to import proxy columns, D15266: Sort milestones by milestone number, not ID, D15267: On workboards, put older milestone columns on the right.Feb 24 2016, 11:15 AM2016-02-24 11:15:31 (UTC+0)
tycho.tatitscheff removed parent revisions: D15267: On workboards, put older milestone columns on the right, D15266: Sort milestones by milestone number, not ID, D15265: Don't try to import proxy columns, D15263: Put boundary spaces around crumb names so double-clicking doesn't flip out, D15264: Filter out archived projects from ProjectProfileView, D15296: Make `bin/diviner generate --repository <repository>` accept identifiers, D15305: Make repository callsigns optional, D15304: Make callsigns editable on repository basic information, D15303: Don't require a callsign to set a repository's local path, D15302: Make serving repositories work with alternate URIs, D15301: Support ID-based repository URIs, and canonicalize repository URIs, D15300: Update import/clear symbols scripts for callsigns, D15299: Disable linter rules by default if a linter standard is defined, D15308: Move Diffusion ReadmeView to PHUIDocumentProView, D15326: Use EditEngine for Almanac Services, Devices, and Networks, D15334: Sort Spaces dropdown by name, not "alphabetical ID", D15340: Correct an old issue with Paste by restoring the file attachment edge, D15338: Fix a couple of column editing issues, D15335: Only hide archived project tags on workboard cards, D15336: L10n: projects → project tags.Feb 24 2016, 12:31 PM2016-02-24 12:31:11 (UTC+0)