Differential D15299

Disable linter rules by default if a linter standard is defined
AcceptedPublic
Actions

Authored by joshuaspence on Feb 18 2016, 4:37 AM.

Tags

None

Referenced Files

	F15452548: D15299.id.diff
	Sat, Mar 29, 5:55 AM

	F15445543: D15299.diff
	Thu, Mar 27, 2:30 PM

	F15434291: D15299.diff
	Tue, Mar 25, 2:54 AM

	F15394601: D15299.id36906.diff
	Sat, Mar 15, 11:57 PM

	F15394458: D15299.id.diff
	Sat, Mar 15, 11:52 PM

	F15394456: D15299.diff
	Sat, Mar 15, 11:52 PM

	F15381526: D15299.diff
	Fri, Mar 14, 8:04 AM

	Unknown Object (File)
	Feb 21 2025, 5:14 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

If a linter standard is defined, disable all linter rules by default. This ensures that only rules whitelisted by the linter standard are used.

Test Plan

N/A

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 10749
Build 13226: Run Core Tests
Build 13225: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,578 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	24 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 209 Passed · 44 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 36906.Feb 18 2016, 4:37 AM

joshuaspence retitled this revision from to Disable linter rules by default if a linter standard is defined.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 18 2016, 4:37 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Feb 18 2016, 10:56 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 18 2016, 10:56 AM

• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM

tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

• TweikerManager added a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:50 PM

epriestley removed a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:52 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

ArcanistLinter.php

7 lines

46%

Loading...

Diff 36906

src/lint/linter/ArcanistLinter.php

Loading...