HomePhabricator

Correct an old issue with Paste by restoring the file attachment edge

Description

Correct an old issue with Paste by restoring the file attachment edge

Summary:
I'm having trouble figuring out exactly what the timeframe on this was, but for a while in November we were not writing edges between pastes and their attached files correctly.

An example of this on this install is here:

https://secure.phabricator.com/P1893

That will start working once the migration runs, but until it does it shows this:

This got fixed so recent stuff works fine, but it looks like WMF updated while the bug was active so they have more affected pastes than we do (we only have about 10).

Test Plan:
Ran this query to find pastes with missing edges:

select id, FROM_UNIXTIME(p.dateCreated) from pastebin_paste p LEFT JOIN edge ON edge.src = p.phid AND edge.type = 25 WHERE edge.dst IS NULL order by id;

Ran the migration.

Verified the edges were fixed.

Viewed one of the affected pastes, things now worked properly.

Reviewers: chad

Reviewed By: chad

Subscribers: 20after4

Differential Revision: https://secure.phabricator.com/D15340

Details

Provenance
epriestleyAuthored on Feb 24 2016, 1:21 AM
epriestleyPushed on Feb 24 2016, 1:31 AM
Reviewer
chad
Differential Revision
D15340: Correct an old issue with Paste by restoring the file attachment edge
Parents
rPe9f4ca6ca338: Redesign PonderQuestionView
Branches
Unknown
Tags
Unknown
Build Status
Buildable 10835
Build 13354: Run Core Tests