Differential D15264

Filter out archived projects from ProjectProfileView
ClosedPublic
Actions

Authored by chad on Feb 12 2016, 8:09 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP1e3a5bd2c0ae: Filter out archived projects from ProjectProfileView

Summary

This just hides them, should still show on "View All".

Test Plan

Hide a Milestone, no longer see it on home. Click "View All", see all Milestones.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36832.Feb 12 2016, 8:09 PM

chad retitled this revision from to Filter out archived projects from ProjectProfileView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 12 2016, 8:09 PM

We should possibly do something like: if this gets zero results, query again without the filter, then show the disabled stuff. Currently, we'll probably show a misleading message ("This project has no milestones") if a project has milestones/subprojects but they're all archived. But we can wait until someone complains.

This revision is now accepted and ready to land.Feb 12 2016, 8:35 PM