Page MenuHomePhabricator

Make callsigns editable on repository basic information
ClosedPublic

Authored by epriestley on Feb 18 2016, 1:57 PM.
Tags
None
Referenced Files
F14344960: D15304.id.diff
Thu, Dec 19, 12:54 AM
F14344175: D15304.id36923.diff
Thu, Dec 19, 12:34 AM
Unknown Object (File)
Tue, Dec 17, 5:20 PM
Unknown Object (File)
Thu, Dec 12, 7:22 PM
Unknown Object (File)
Wed, Dec 11, 4:31 PM
Unknown Object (File)
Sat, Dec 7, 1:26 AM
Unknown Object (File)
Sun, Dec 1, 9:23 AM
Unknown Object (File)
Sun, Dec 1, 1:54 AM
Subscribers
None

Details

Summary

Ref T4245. This is a prelude to removing them from the "create" screen.

Currently, if you try to delete the callsign you get an unceremonious database error, but the next diff (or maybe two) will permit that, so I didn't put any "this is required yada yada" text in.

This could also maybe use some big flashing warning lights and a "if you edit this, all your URIs break" but I'll save that for later.

Test Plan

Changed the callsign for a repository.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make callsigns editable on repository basic information.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/repository/editor/PhabricatorRepositoryEditor.php
471

lul

src/applications/repository/storage/PhabricatorRepository.php
320

wut

327

haha

This revision is now accepted and ready to land.Feb 18 2016, 4:18 PM

yeah I was like "wtf?" and then I was like "oh.. wtf?"

This revision was automatically updated to reflect the committed changes.