Page MenuHomePhabricator

Correct an old issue with Paste by restoring the file attachment edge
ClosedPublic

Authored by epriestley on Feb 24 2016, 1:25 AM.

Details

Summary

I'm having trouble figuring out exactly what the timeframe on this was, but for a while in November we were not writing edges between pastes and their attached files correctly.

An example of this on this install is here:

https://secure.phabricator.com/P1893

That will start working once the migration runs, but until it does it shows this:

This got fixed so recent stuff works fine, but it looks like WMF updated while the bug was active so they have more affected pastes than we do (we only have about 10).

Test Plan

Ran this query to find pastes with missing edges:

select id, FROM_UNIXTIME(p.dateCreated) from pastebin_paste p LEFT JOIN edge ON edge.src = p.phid AND edge.type = 25 WHERE edge.dst IS NULL order by id;

Ran the migration.

Verified the edges were fixed.

Viewed one of the affected pastes, things now worked properly.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 36994.Feb 24 2016, 1:25 AM
epriestley retitled this revision from to Correct an old issue with Paste by restoring the file attachment edge.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Feb 24 2016, 1:30 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 24 2016, 1:30 AM
This revision was automatically updated to reflect the committed changes.

Looks like it fixed stuff.