Page MenuHomePhabricator

Support ID-based repository URIs, and canonicalize repository URIs
ClosedPublic

Authored by epriestley on Feb 18 2016, 12:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 4, 2:17 PM
Unknown Object (File)
Mar 11 2026, 3:49 AM
Unknown Object (File)
Feb 26 2026, 5:20 PM
Unknown Object (File)
Feb 5 2026, 7:17 AM
Unknown Object (File)
Jan 29 2026, 7:38 PM
Unknown Object (File)
Jan 22 2026, 7:12 AM
Unknown Object (File)
Jan 7 2026, 3:15 AM
Unknown Object (File)
Dec 22 2025, 8:49 PM
Subscribers
None

Details

Summary

Ref T4245. Make /diffusion/123/ work, but redirect the user to /diffusion/XYZ/ if the repository has a callsign.

(Right now, every repository has a callsign, so this always redirects.)

Also redirect /R123:abcdef if the repository has a callsign.

Also also, move the Pull garbage collector somewhere more sensible.

Test Plan
  • Added test coverage.
  • Visited /diffusion/1/, was redirected.
  • Visited /diffusion/R1:abcdef, was redirected.
  • Browsed Diffusion normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support ID-based repository URIs, and canonicalize repository URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Fix bad regex for repositories with multiple-digit IDs, like "18".
  • Also fix the other copy of the dodgy regexp.
This revision is now accepted and ready to land.Feb 18 2016, 4:14 PM
This revision was automatically updated to reflect the committed changes.