Page MenuHomePhabricator

Support ID-based repository URIs, and canonicalize repository URIs
ClosedPublic

Authored by epriestley on Feb 18 2016, 12:22 PM.
Tags
None
Referenced Files
F15533697: D15301.diff
Wed, Apr 23, 9:24 PM
F15488367: D15301.id36908.diff
Thu, Apr 10, 9:40 PM
F15460890: D15301.id36910.diff
Tue, Apr 1, 3:12 AM
F15452530: D15301.id.diff
Sat, Mar 29, 5:49 AM
F15448382: D15301.diff
Fri, Mar 28, 4:34 AM
F15434347: D15301.id.diff
Mar 25 2025, 3:06 AM
F15434346: D15301.id36920.diff
Mar 25 2025, 3:06 AM
F15434345: D15301.id36908.diff
Mar 25 2025, 3:06 AM
Subscribers
None

Details

Summary

Ref T4245. Make /diffusion/123/ work, but redirect the user to /diffusion/XYZ/ if the repository has a callsign.

(Right now, every repository has a callsign, so this always redirects.)

Also redirect /R123:abcdef if the repository has a callsign.

Also also, move the Pull garbage collector somewhere more sensible.

Test Plan
  • Added test coverage.
  • Visited /diffusion/1/, was redirected.
  • Visited /diffusion/R1:abcdef, was redirected.
  • Browsed Diffusion normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support ID-based repository URIs, and canonicalize repository URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Fix bad regex for repositories with multiple-digit IDs, like "18".
  • Also fix the other copy of the dodgy regexp.
This revision is now accepted and ready to land.Feb 18 2016, 4:14 PM
This revision was automatically updated to reflect the committed changes.