Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings
- Commits
- rARCf2a3fdf5e393: Fix text lint issues
arc lint --everything
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 4476 Build 4490: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 105 ms | ArcanistTextLinterTestCase::testLinter | |
| 119 ms | ArcanistBaseCommitParserTestCase::testBasics | |
| 97 ms | ArcanistBaseCommitParserTestCase::testHalt | |
| 124 ms | ArcanistBaseCommitParserTestCase::testJump | |
| 140 ms | ArcanistBaseCommitParserTestCase::testJumpReturn | |
| View Full Test Results (1 Failed · 69 Passed · 6 Skipped) |
Event Timeline
| src/lint/linter/ArcanistTextLinter.php | ||
|---|---|---|
| 18 ↗ | (On Diff #28017) | This causes a behavioral change, right? That's maaaaybe OK but likely surprising for users... |
| src/lint/linter/ArcanistTextLinter.php | ||
|---|---|---|
| 18 ↗ | (On Diff #28017) | Yes it does, but it seemed necessary to make this work. Otherwise, we can't use max_line_length = in an .editorconfig file to mean "no maximum line length". We could maybe tweak this to use some non-null sentinel value I suppose. |