Page MenuHomePhabricator

Fix text lint issues
ClosedPublic

Authored by joshuaspence on Feb 3 2015, 10:20 AM.
Tags
None
Referenced Files
F12846747: D11640.diff
Fri, Mar 29, 1:31 AM
Unknown Object (File)
Sun, Mar 24, 1:08 AM
Unknown Object (File)
Sat, Mar 23, 12:44 AM
Unknown Object (File)
Wed, Mar 20, 1:45 AM
Unknown Object (File)
Thu, Mar 14, 5:57 PM
Unknown Object (File)
Thu, Mar 14, 5:53 PM
Unknown Object (File)
Fri, Mar 1, 11:34 AM
Unknown Object (File)
Fri, Mar 1, 10:46 AM
Subscribers

Details

Summary

Ref T5105. This is a proof-of-concept for D11458.

Test Plan

arc lint --everything

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4449
Build 4463: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Fix text lint issues.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
src/lint/linter/ArcanistTextLinter.php
18 ↗(On Diff #28017)

This causes a behavioral change, right? That's maaaaybe OK but likely surprising for users...

src/lint/linter/ArcanistTextLinter.php
18 ↗(On Diff #28017)

Yes it does, but it seemed necessary to make this work. Otherwise, we can't use max_line_length = in an .editorconfig file to mean "no maximum line length". We could maybe tweak this to use some non-null sentinel value I suppose.

joshuaspence edited edge metadata.

Change end of line character

epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:39 PM
This revision was automatically updated to reflect the committed changes.