Page MenuHomePhabricator

Fix text lint issues
ClosedPublic

Authored by joshuaspence on Feb 3 2015, 10:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 23, 1:56 PM
Unknown Object (File)
Sun, Jul 21, 9:32 AM
Unknown Object (File)
Sat, Jul 20, 9:10 PM
Unknown Object (File)
Wed, Jul 17, 10:16 AM
Unknown Object (File)
Sat, Jul 13, 4:58 PM
Unknown Object (File)
Sat, Jul 13, 7:31 AM
Unknown Object (File)
Fri, Jul 12, 4:49 AM
Unknown Object (File)
Thu, Jul 11, 9:47 PM
Subscribers

Details

Summary

Ref T5105. This is a proof-of-concept for D11458.

Test Plan

arc lint --everything

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 4273
Build 4286: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
98 msArcanistTextLinterTestCase::testLinter
726 msArcanistCSSLintLinterTestCase::testLinter
110 msArcanistCSSLintLinterTestCase::testVersion
121 msArcanistChmodLinterTestCase::testLinter
245 msArcanistClosureLinterTestCase::testLinter
View Full Test Results (1 Failed · 53 Passed · 6 Skipped)

Event Timeline

joshuaspence retitled this revision from to Fix text lint issues.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
src/lint/linter/ArcanistTextLinter.php
18

This causes a behavioral change, right? That's maaaaybe OK but likely surprising for users...

src/lint/linter/ArcanistTextLinter.php
18

Yes it does, but it seemed necessary to make this work. Otherwise, we can't use max_line_length = in an .editorconfig file to mean "no maximum line length". We could maybe tweak this to use some non-null sentinel value I suppose.

joshuaspence edited edge metadata.

Change end of line character

epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:39 PM
This revision was automatically updated to reflect the committed changes.