Differential D12913

Add some class constants to PhutilEditorConfig
ClosedPublic
Actions

Authored by joshuaspence on May 18 2015, 9:19 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings

Commits

rPHU72ea80ff1468: Add some class constants to PhutilEditorConfig

Summary

Ref T5105. Add some class constants to the PhutilEditorConfig class to avoid hardcoded strings everywhere.

Test Plan

See D11458.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31066.May 18 2015, 9:19 PM

joshuaspence retitled this revision from to Add some class constants to PhutilEditorConfig.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 18 2015, 9:19 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence added a child revision: D11458: Modify `ArcanistTextLinter` to respect `.editorconfig`.May 18 2015, 9:20 PM

joshuaspence mentioned this in D11458: Modify `ArcanistTextLinter` to respect `.editorconfig`.May 18 2015, 9:24 PM

epriestley accepted this revision.May 19 2015, 1:38 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 1:38 PM

Closed by commit rPHU72ea80ff1468: Add some class constants to PhutilEditorConfig (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 20 2015, 1:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilEditorConfig.php

53 lines

Diff 31177

View Options

src/parser/PhutilEditorConfig.php

Add some class constants to PhutilEditorConfigClosedPublicActions