Page MenuHomePhabricator
Differential D11642

Fix text lint issues
ClosedPublic
Actions

Authored by joshuaspence on Feb 3 2015, 10:42 AM.
Tags
None
Referenced Files
F15587673: D11642.diff
Fri, May 9, 12:00 AM
F15576768: D11642.id28258.diff
Tue, May 6, 10:37 AM
F15572582: D11642.id.diff
Mon, May 5, 4:39 PM
F15570121: D11642.id28258.diff
Sun, May 4, 10:58 AM
F15567524: D11642.diff
Fri, May 2, 8:23 AM
F15547748: D11642.diff
Sat, Apr 26, 8:18 PM
F15546572: D11642.id28051.diff
Sat, Apr 26, 4:10 PM
F15500814: D11642.id28312.diff
Sun, Apr 13, 7:25 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings
Commits
Restricted Diffusion Commit
rP2a2b47326c81: Fix text lint issues
Summary

Ref T5105. This is a proof-of-concept for D11458.

Test Plan

arc lint --everything

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28020.Feb 3 2015, 10:42 AM
joshuaspence retitled this revision from to Fix text lint issues.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D11458: Modify `ArcanistTextLinter` to respect `.editorconfig`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 3 2015, 10:42 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley added inline comments.Feb 3 2015, 7:47 PM
.arclint
17–40

These don't seem related to text lint?

joshuaspence added inline comments.Feb 3 2015, 7:55 PM
.arclint
17–40

Oh whoops... I disabled these to make the output of arc lint less noisy.

joshuaspence updated this revision to Diff 28051.Feb 3 2015, 7:56 PM
joshuaspence edited edge metadata.

derp

epriestley accepted this revision.Feb 3 2015, 7:57 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 7:57 PM
joshuaspence updated this object.Feb 10 2015, 8:47 AM
joshuaspence edited edge metadata.
joshuaspence added a task: T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings.
joshuaspence updated this revision to Diff 28258.Feb 10 2015, 10:00 AM

Minor changes

joshuaspence updated this revision to Diff 28259.Feb 10 2015, 10:09 AM

Minor changes

Closed by commit rP2a2b47326c81: Fix text lint issues (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 11 2015, 8:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
19 lines
21 lines
1 line
src/
applications/
diffusion/
data/
__tests__/
22 lines
docs/
book/
34 lines
44 lines
394 lines
56 lines
webroot/
rsrc/
externals/
javelin/
10 lines

Diff 28312

View Options

.arclint

Loading...
View Options

.editorconfig

Loading...
View Options

LICENSE

Loading...
View Options

src/applications/diffusion/data/__tests__/DiffusionGitBranchTestCase.php

Loading...
View Options

src/docs/book/contributor.book

Loading...
View Options

src/docs/book/flavor.book

Loading...
View Options

src/docs/book/phabricator.book

Loading...
View Options

src/docs/book/user.book

Loading...
View Options

webroot/rsrc/externals/javelin/LICENSE

Loading...
Phabricator · Built by Phacility