Page MenuHomePhabricator

Fix text lint issues
ClosedPublic

Authored by joshuaspence on Feb 3 2015, 10:20 AM.
Tags
None
Referenced Files
F18441297: D11640.id.diff
Sun, Aug 31, 4:23 PM
F18440472: D11640.id28292.diff
Sun, Aug 31, 3:45 PM
F18440305: D11640.id28292.diff
Sun, Aug 31, 3:39 PM
F18439636: D11640.id28017.diff
Sun, Aug 31, 3:13 PM
F18432779: D11640.id.diff
Sun, Aug 31, 7:02 AM
F18410860: D11640.diff
Sat, Aug 30, 5:25 AM
F18405547: D11640.id28291.diff
Fri, Aug 29, 11:35 PM
F18405450: D11640.diff
Fri, Aug 29, 11:30 PM
Subscribers

Details

Summary

Ref T5105. This is a proof-of-concept for D11458.

Test Plan

arc lint --everything

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 4452
Build 4466: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
100 msArcanistTextLinterTestCase::testLinter
68 msArcanistBaseCommitParserTestCase::testBasics
63 msArcanistBaseCommitParserTestCase::testHalt
64 msArcanistBaseCommitParserTestCase::testJump
64 msArcanistBaseCommitParserTestCase::testJumpReturn
View Full Test Results (1 Failed · 69 Passed · 6 Skipped)

Event Timeline

joshuaspence retitled this revision from to Fix text lint issues.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
src/lint/linter/ArcanistTextLinter.php
18 ↗(On Diff #28017)

This causes a behavioral change, right? That's maaaaybe OK but likely surprising for users...

src/lint/linter/ArcanistTextLinter.php
18 ↗(On Diff #28017)

Yes it does, but it seemed necessary to make this work. Otherwise, we can't use max_line_length = in an .editorconfig file to mean "no maximum line length". We could maybe tweak this to use some non-null sentinel value I suppose.

joshuaspence edited edge metadata.

Change end of line character

epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:39 PM
This revision was automatically updated to reflect the committed changes.