Identify anywhere we didn't use icons where barColor was used
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	chad
	May 28 2015, 4:18 PM

Description

We moved PHUIObjectItemListView to icons + color instead of barColor. I should do a sweep of any place (ie, harbormaster) where barColors were not moved to icons.

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php:      $item->setBarColor(HarbormasterBuildable::getBuildableStatusColor(
src/applications/phortune/controller/PhortuneAccountViewController.php:          $item->setBarColor('green');
src/applications/phortune/controller/PhortuneMerchantViewController.php:          $item->setBarColor('green');
src/applications/phortune/controller/PhortuneMerchantViewController.php:          $item->setBarColor('yellow');
src/applications/phrequent/query/PhrequentSearchEngine.php:        $item->setBarColor('green');
src/applications/phriction/controller/PhrictionDiffController.php:        $item->setBarColor('green');
src/applications/phriction/controller/PhrictionDiffController.php:        $item->setBarColor('red');
src/applications/phriction/controller/PhrictionHistoryController.php:        ->setBarColor($color)
src/applications/ponder/query/PonderQuestionSearchEngine.php:      $item->setBarColor(
src/applications/project/view/ProjectBoardTaskCard.php:      ->setBarColor($bar_color);
src/applications/releeph/controller/product/ReleephProductViewController.php:        $item->setBarColor('orange');
src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php:      $enabled_item->setBarColor('green');

Revisions and Commits

rP Phabricator
	Closed		D13053 [Redesign] Update Drydock UI
	Closed		D13050 [Redesign] Update Config UI
	Closed		D13049 [Redesign] Update Conduit UI
		D13059	rP13f9f209df06 [Redesign] Remove remaining barColor callsites

Related Objects
Search...

Status	Assigned	Task
Open	None	T9303 Improve Phacility Onboarding/NUX
Resolved	epriestley	T7673 Make "Log Out" on Phacility instances behave in a way better aligned with user expectation
Open	None	T7303 Provide OAuth access to Conduit
Open	None	T13201 Develop a more comprehensive approach for previews/drafts on edit screens
Open	epriestley	T4768 Phabricator silently overwrites concurrent changes (no conflict detection)
Resolved	epriestley	T6226 Conduit-created task always results in [Reopened] tag in the email subject
Wontfix	epriestley	T1394 Support creating audits with inline comments through the API
Resolved	btrahan	T6262 Create a new Phriction document via Conduit interface
Resolved	epriestley	T6501 Expose project icons and other metadata through project.query
Resolved	epriestley	T10512 Implement `user.search` Conduit API method
Resolved	epriestley	T5873 Update Conduit for ApplicationTransactions, CustomFields and Edges
Duplicate	None	T7794 Differential revision list "draft notification" bubble should ignore deleted drafts
Resolved	None	T5031 Draft Comment Persists After Submission
Resolved	epriestley	T10034 Plan the future of Maniphest task relationships
Resolved	None	T7820 Add "Closed, Duplicate" option to Status Action in Maniphest
Resolved	epriestley	T8434 Accommodate the "Security" workflow
Open	None	T4316 Allow a comment to be added on the Maniphest edit interface
Invalid	None	T9238 Field-level policy controls are not made clear in the UI
Resolved	None	T9527 Confusing "... shifted this object from the S1 Public space to..."
Resolved	epriestley	T9132 Build an ApplicationEditor abstraction
Resolved	epriestley	T5752 Navigation menus should work correctly on mobile by default
Open	None	T8175 Mobile always collapses long crumbs
Resolved	chad	T7429 Update tour screenshots on dot org
Resolved	chad	T8099 Mid-2015 Phabricator Redesign
Resolved	chad	T8341 Identify anywhere we didn't use icons where barColor was used