Page MenuHomePhabricator
Differential D13059

[Redesign] Remove remaining barColor callsites
ClosedPublic
Actions

Authored by chad on May 28 2015, 10:15 PM.
Tags
None
Referenced Files
F14055811: D13059.id31507.diff
Sat, Nov 16, 4:00 PM
F14037638: D13059.diff
Sun, Nov 10, 5:41 PM
F14004659: D13059.id.diff
Sun, Oct 27, 12:37 AM
F13988159: D13059.id31507.diff
Oct 21 2024, 1:35 PM
F13973128: D13059.id31508.diff
Oct 17 2024, 11:15 PM
Unknown Object (File)
Sep 13 2024, 9:54 PM
Unknown Object (File)
Sep 9 2024, 7:29 PM
Unknown Object (File)
Aug 17 2024, 2:06 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8341: Identify anywhere we didn't use icons where barColor was used
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP13f9f209df06: [Redesign] Remove remaining barColor callsites
Summary

Ref T8099, Fixes T8341. Switches all remaining callsites to setBarColor to use setStatusIcon (sans workboards).

Test Plan

Test each of the applications I changed as I could (not Releeph).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 31507.May 28 2015, 10:15 PM
chad retitled this revision from to [Redesign] Remove remaining barColor callsites.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added tasks: T8099: Mid-2015 Phabricator Redesign, T8341: Identify anywhere we didn't use icons where barColor was used.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 28 2015, 10:15 PM
epriestley accepted this revision.May 28 2015, 10:16 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 28 2015, 10:16 PM
chad added a comment.May 28 2015, 10:17 PM

oh dear, ponder is looking better.

Closed by commit rP13f9f209df06: [Redesign] Remove remaining barColor callsites (authored by chad, committed by chad). · Explain WhyMay 28 2015, 10:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
view/
8 lines
harbormaster/
query/
3 lines
phortune/
controller/
3 lines
4 lines
phrequent/
query/
2 lines
ponder/
constants/
10 lines
query/
10 lines
releeph/
controller/
product/
2 lines
infrastructure/
customfield/
config/
2 lines

Diff 31508

View Options

src/applications/audit/view/PhabricatorAuditListView.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/phortune/controller/PhortuneAccountViewController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneMerchantViewController.php

Loading...
View Options

src/applications/phrequent/query/PhrequentSearchEngine.php

Loading...
View Options

src/applications/ponder/constants/PonderQuestionStatus.php

Loading...
View Options

src/applications/ponder/query/PonderQuestionSearchEngine.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductViewController.php

Loading...
View Options

src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php

Loading...
Phabricator · Built by Phacility