Maniphest T10417

Active Differentials are wrongly indicated as blocking when "request changes" is used
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	eadler
	Feb 22 2016, 7:57 PM

Tags

Referenced Files

None

Subscribers

Description

Steps to reproduce

S has a change for which A and B are reviewers
A requests changes on the review
B accepts the review
B goes to look at "Active Differential Revisions"

Actual behavior:

B sees the review under "Action Required"

Expected behavior:

B sees the review under "Waiting on Others"

this is because there is nothing B can do other than request A accept the review (or remove A manually)

Related Objects

Mentioned In: T10939: Support for OWNERS files
Mentioned Here: T1279: Show per-reviewer status in Differential revision reviewer list
T6596: Blocking reviewers continue appearing as blocking even after they accept a revision
T8080: Differential shown as "Blocking Others"
T9372: Plan the future of "Bucketing" Query UIs
T10031: Differential revision listed as "blocking others", if reviewer already accepted

Event Timeline

eadler created this task.Feb 22 2016, 7:57 PM

eadler added projects: Differential, Restricted Project.

eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

eadler added a subscriber: scode.

chad closed this task as a duplicate of T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist.Feb 22 2016, 8:06 PM

See also T1279#42118, T9372, T10031, T8080, T6596

I promise I searched first! Thanks for the info

epriestley mentioned this in T10939: Support for OWNERS files.May 15 2016, 4:36 PM