Page MenuHomePhabricator

Active Differentials are wrongly indicated as blocking when "request changes" is used
Closed, DuplicatePublic

Description

Steps to reproduce

  1. S has a change for which A and B are reviewers
  2. A requests changes on the review
  3. B accepts the review
  4. B goes to look at "Active Differential Revisions"

Actual behavior:

  1. B sees the review under "Action Required"

Expected behavior:

  1. B sees the review under "Waiting on Others"

this is because there is nothing B can do other than request A accept the review (or remove A manually)

Event Timeline

eadler created this task.Feb 22 2016, 7:57 PM
eadler added projects: Differential, Restricted Project.
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
eadler added a subscriber: scode.

I promise I searched first! Thanks for the info