Ref T4675. Getting the policy control into the batch editor is a bit tricky since the policy control is JS wizardy bound to a single object in the vanilla case. Tossing up this non-working diff for guidance as I don't want to waste time on a bad solution. I think we need to get this working well for the herald case too. We could possibly have a weaker version that doesn't allow for creating new custom policies.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4675: Support bulk editing object policies and other fields with complex UI controls
NA
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T4675
- Lint
Lint Errors Severity Location Code Message Error webroot/rsrc/js/application/maniphest/behavior-batch-editor.js:73 JSHintW086 JSHintW086 - Unit
No Test Coverage
Event Timeline
Comment Actions
oh man this is a huge mess
I think the cleanest approach is to do something similar to the Typeahead:
- Separate the control into "template" (dumb blob of HTML) and "js magic" parts, like the Tokenizer/Typeahead are.
- Put the "js magic" part in some separate Javascript class (JX.PhabricatorPolicyControl).
- Make the existing behavior a thin wrapper around "pass all this stuff to the JS magic", so it basically does new JX.PhabricatorPolicyControl().setStuff(...).start().
- From the batch editor, drop the template into the document and then create a new JX.PhabricatorPolicyControl and call all the set() junk to give it magic.
This is probably an ass-ton of work. I don't think this feature is too important, so maybe deprioritize it for now? If anyone runs into an issue I can give them a 5 line script to make the adjustment they want. Or take a shot at the above, but I was thinking this was like a 5-minute fix when prioritizing.