Page MenuHomePhabricator

Move Differential to EditEngine comments
ClosedPublic

Authored by epriestley on Dec 28 2016, 6:44 PM.
Tags
None
Referenced Files
F15464641: D17106.id.diff
Wed, Apr 2, 11:41 AM
F15461803: D17106.id41144.diff
Tue, Apr 1, 11:24 AM
F15461138: D17106.id41165.diff
Tue, Apr 1, 5:33 AM
F15442751: D17106.diff
Thu, Mar 27, 12:16 AM
F15431845: D17106.id.diff
Mon, Mar 24, 2:51 PM
F15427281: D17106.diff
Sun, Mar 23, 1:31 PM
F15416681: D17106.id41144.diff
Thu, Mar 20, 12:57 PM
F15377751: D17106.id.diff
Thu, Mar 13, 10:39 AM
Subscribers
None

Details

Summary

Ref T11114. This is a transitional change that breaks a bunch of stuff. I'll hold it until I've restored features.

This stuff works:

  • Commenting.
  • Subscribers/tags/reviewers.
  • Pinning.
  • Drafts.

This stuff does not work yet:

  • Preview of inline comments.
  • Probably submitting inlines, whatsoever.
  • Comment-area warnings like "There are failing tests."
  • All meaningful actions (accept, reject, etc).
Test Plan

Commented on a revision. Essentially nothing else works yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable