Page MenuHomePhabricator

Move Differential to EditEngine comments
ClosedPublic

Authored by epriestley on Dec 28 2016, 6:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 2:36 PM
Unknown Object (File)
Tue, Mar 26, 2:36 PM
Unknown Object (File)
Tue, Mar 26, 2:36 PM
Unknown Object (File)
Tue, Mar 26, 2:36 PM
Unknown Object (File)
Fri, Mar 15, 1:53 PM
Unknown Object (File)
Sun, Mar 10, 4:28 PM
Unknown Object (File)
Feb 7 2024, 1:54 AM
Unknown Object (File)
Feb 3 2024, 1:37 PM
Subscribers
None

Details

Summary

Ref T11114. This is a transitional change that breaks a bunch of stuff. I'll hold it until I've restored features.

This stuff works:

  • Commenting.
  • Subscribers/tags/reviewers.
  • Pinning.
  • Drafts.

This stuff does not work yet:

  • Preview of inline comments.
  • Probably submitting inlines, whatsoever.
  • Comment-area warnings like "There are failing tests."
  • All meaningful actions (accept, reject, etc).
Test Plan

Commented on a revision. Essentially nothing else works yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable