Page MenuHomePhabricator

Move Differential to EditEngine comments
ClosedPublic

Authored by epriestley on Dec 28 2016, 6:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 7:34 AM
Unknown Object (File)
Wed, Jan 15, 11:29 AM
Unknown Object (File)
Wed, Jan 15, 2:21 AM
Unknown Object (File)
Thu, Jan 9, 8:38 PM
Unknown Object (File)
Fri, Jan 3, 10:21 PM
Unknown Object (File)
Dec 28 2024, 2:31 AM
Unknown Object (File)
Dec 27 2024, 12:01 PM
Unknown Object (File)
Dec 21 2024, 3:38 AM
Subscribers
None

Details

Summary

Ref T11114. This is a transitional change that breaks a bunch of stuff. I'll hold it until I've restored features.

This stuff works:

  • Commenting.
  • Subscribers/tags/reviewers.
  • Pinning.
  • Drafts.

This stuff does not work yet:

  • Preview of inline comments.
  • Probably submitting inlines, whatsoever.
  • Comment-area warnings like "There are failing tests."
  • All meaningful actions (accept, reject, etc).
Test Plan

Commented on a revision. Essentially nothing else works yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable