Page MenuHomePhabricator

Move Differential to EditEngine comments
ClosedPublic

Authored by epriestley on Dec 28 2016, 6:44 PM.
Tags
None
Referenced Files
F17946423: D17106.id.diff
Thu, Jul 31, 2:27 PM
F17926468: D17106.diff
Wed, Jul 30, 1:10 PM
F17845781: D17106.diff
Sun, Jul 27, 4:00 AM
Unknown Object (File)
Jul 5 2025, 6:29 PM
Unknown Object (File)
Jun 29 2025, 1:53 PM
Unknown Object (File)
Jun 28 2025, 12:44 PM
Unknown Object (File)
Jun 3 2025, 7:50 AM
Unknown Object (File)
May 29 2025, 8:54 AM
Subscribers
None

Details

Summary

Ref T11114. This is a transitional change that breaks a bunch of stuff. I'll hold it until I've restored features.

This stuff works:

  • Commenting.
  • Subscribers/tags/reviewers.
  • Pinning.
  • Drafts.

This stuff does not work yet:

  • Preview of inline comments.
  • Probably submitting inlines, whatsoever.
  • Comment-area warnings like "There are failing tests."
  • All meaningful actions (accept, reject, etc).
Test Plan

Commented on a revision. Essentially nothing else works yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable