Page MenuHomePhabricator

Allow any EditEngine comment form to be pinned
ClosedPublic

Authored by epriestley on Dec 28 2016, 5:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 7:37 PM
Unknown Object (File)
Tue, Mar 26, 7:36 PM
Unknown Object (File)
Tue, Mar 26, 7:36 PM
Unknown Object (File)
Tue, Mar 26, 7:10 PM
Unknown Object (File)
Fri, Mar 15, 10:33 PM
Unknown Object (File)
Feb 3 2024, 1:37 PM
Unknown Object (File)
Jan 22 2024, 3:55 AM
Unknown Object (File)
Dec 27 2023, 9:04 AM
Subscribers
None

Details

Summary

Fixes T12049. This expands "Haunted" comment panels to EditEngine, and by extension to all EditEngine applications.

Eventual goal is to remove custom commenting code in Differential and replace it with EditEngine code.

Changes from current "haunt" mode:

  • This only has one mode ("pinned"), not two ("pinned", "pinned with preview"). There's an inline preview and scroll behavior is a little better.
  • Now has a UI action button.

Slightly tricky stuff:

  • This interacts with "Fullscreen" mode since it doesn't make sense to pin a full-screen comment area.
  • This should only be available for comments, not for remarkup fields like "Description" in "Edit Task".
Test Plan
  • Pinned/unpinned in Maniphest.
  • Pinned/fullscreened/unfullscreened/unpinned.
  • Checked that "Edit Task" doesn't allow pinning for "Description", etc.
  • Pressed "?", read about pressing "Z".
  • Pressed "Z".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable