Page MenuHomePhabricator

If there's an anchor in the URL in Differential, don't stick to the bottom of the page as content loads
ClosedPublic

Authored by epriestley on May 16 2017, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 2:40 PM
Unknown Object (File)
Sat, Dec 14, 1:44 AM
Unknown Object (File)
Fri, Dec 6, 4:24 AM
Unknown Object (File)
Wed, Nov 27, 9:46 AM
Unknown Object (File)
Tue, Nov 26, 3:03 AM
Unknown Object (File)
Mon, Nov 25, 11:40 PM
Unknown Object (File)
Nov 9 2024, 1:40 PM
Unknown Object (File)
Nov 3 2024, 1:54 PM
Subscribers
None

Details

Summary

Fixes T11784. A lot of things are interacting here, but this probably gets slightly better results slightly more often?

Basically:

  • When we load content, we try to keep the viewport "stable" on the page, so the page doesn't jump around like crazy.
  • If you're near the top or bottom of the page, we try to stick to the top (e.g., reading the summary) or bottom (e.g., writing a comment).
  • But, if you followed an anchor to a comment that's close to the bottom of the page, we might stick to the bottom intead of staying with the anchor.

Kind of do a better job by not sticking to the bottom if you have an anchor. This will get things wrong if you follow an anchor, scroll down, start writing a comment, etc. But this whole thing is a pile of guesses anyway.

Test Plan
  • Followed an anchor, saw non-sticky stabilization.
  • Loaded the page normally, scrolled to the bottom real fast, saw sticky stabilization.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable