Page MenuHomePhabricator

When stabilizing document scroll position for diffs, stick to anchors harder
ClosedPublic

Authored by epriestley on Jun 1 2017, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 9 2025, 8:24 PM
Unknown Object (File)
May 7 2025, 12:24 AM
Unknown Object (File)
Apr 23 2025, 1:47 PM
Unknown Object (File)
Apr 21 2025, 3:35 PM
Unknown Object (File)
Apr 20 2025, 11:37 AM
Unknown Object (File)
Apr 6 2025, 11:32 PM
Unknown Object (File)
Mar 24 2025, 4:13 AM
Unknown Object (File)
Mar 22 2025, 1:53 PM
Subscribers
None

Details

Summary

Ref T12779. Try a little harder to get the autoscroll heuristic right, but also just stick to anchors if the URL has an anchor and the scroll position is near that anchor.

Test Plan
  • Loaded an anchored diff at a bunch of window sizes, seemed pretty sticky.
  • Added usleep(100000 * mt_rand(1, 15)) to ChangesetViewController to make changesets load slowly and in random order, reloaded a bunch of times while scrolling around, things appeared reasonable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable