Page MenuHomePhabricator

When stabilizing document scroll position for diffs, stick to anchors harder
ClosedPublic

Authored by epriestley on Jun 1 2017, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 4:15 AM
Unknown Object (File)
Sun, Feb 9, 4:15 AM
Unknown Object (File)
Sun, Feb 9, 4:15 AM
Unknown Object (File)
Mon, Jan 27, 9:49 AM
Unknown Object (File)
Fri, Jan 24, 9:26 PM
Unknown Object (File)
Fri, Jan 24, 9:25 PM
Unknown Object (File)
Fri, Jan 24, 9:25 PM
Unknown Object (File)
Fri, Jan 24, 6:10 PM
Subscribers
None

Details

Summary

Ref T12779. Try a little harder to get the autoscroll heuristic right, but also just stick to anchors if the URL has an anchor and the scroll position is near that anchor.

Test Plan
  • Loaded an anchored diff at a bunch of window sizes, seemed pretty sticky.
  • Added usleep(100000 * mt_rand(1, 15)) to ChangesetViewController to make changesets load slowly and in random order, reloaded a bunch of times while scrolling around, things appeared reasonable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable