Page MenuHomePhabricator

Show icons and disabled/archived/closed results in typahead dynamic list
ClosedPublic

Authored by epriestley on Feb 14 2014, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 8:22 AM
Unknown Object (File)
Thu, Nov 14, 7:24 AM
Unknown Object (File)
Mon, Nov 11, 2:31 AM
Unknown Object (File)
Sun, Nov 10, 12:44 PM
Unknown Object (File)
Thu, Oct 24, 10:35 PM
Unknown Object (File)
Oct 21 2024, 1:48 AM
Unknown Object (File)
Oct 18 2024, 3:37 AM
Unknown Object (File)
Oct 7 2024, 8:34 PM
Tokens
"Haypence" token, awarded by btrahan.

Details

Summary

Ref T4420. This is mostly a design change, but addresses two functional issues:

  1. Many sources exclude disabled accounts, system agents, archived projects, etc. It is rare to select these, but excluding them completely is too severe, and we've made more than a handful of changes over time to replace a "users" endpoint with an "accounts" endpoint (to include disabled users) or similar. Instead, always show these results, but sort them last and use a special style to clearly mark them as closed, disabled, or otherwise unusual.
    • As a practical consequence, all the similar endpoints can now be merged, so "accounts" and "users" return the exact same result sets.
  2. Increasingly, sources can return multiple object types in a single list. For example, "CC" can have a user or mailing list, and soon a project or repository. However, the result list is fairly homogenous across types and it isn't easy to quickly pick out projects vs users. To help with this, add icons showing the result type.
Test Plan

{F113079}

(The main search results get touched here too, I verified they didn't blow up.)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped