Differential D17656
Don't filter "Closed" results (disabled users, bots, mailing lists) out of global typeahead Authored by epriestley on Apr 11 2017, 7:11 PM. Tags None Referenced Files
Subscribers
Details Ref T12538. Currently, we filter disabled users, mailing lists, and bots out of the global search typehead unless only disabled users, mailing lists and bots appear in the results. This rule interacts badly with other rules when a query matches both projects and bot/mailing list users. There are probably broader fixes available here but I think this resolves the immediate issue without too much collateral damage. 
Diff Detail
Event TimelineComment Actions I don't think "exact match" is actually the rule anywhere. This change makes this typeahead work less like other typeaheads than it did before this change. The rule for most typeaheads is "only show closed results if the entire result set is closed". This removes that rule, because of the bad interaction it has in T12538. This rule is probably not the right rule to use anywhere, but it is more obviously wrong here than in other contexts. Comment Actions Can we still filter disabled items? I'd agree bots and mailing lists should show, but I don't want old projects / etc surfacing... unless I'm missing something? |