Filter archived packages out of the "controlling packages" query earlier
ClosedPublic
Actions

Authored by epriestley on Feb 27 2017, 8:11 PM.

Tags

None

Referenced Files

	F15391237: D17427.id41907.diff
	Sat, Mar 15, 8:56 AM

	F15381896: D17427.diff
	Fri, Mar 14, 9:49 AM

	F15308353: D17427.id41907.diff
	Thu, Mar 6, 6:11 AM

	F15293638: D17427.id41906.diff
	Wed, Mar 5, 4:30 AM

	F15285814: D17427.id.diff
	Tue, Mar 4, 4:09 PM

	F15284932: D17427.diff
	Tue, Mar 4, 10:59 AM

	Unknown Object (File)
	Mar 1 2025, 10:09 PM

	Unknown Object (File)
	Feb 21 2025, 3:13 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12319: Investigate an Owners-related performance issue on revision detail pages

Commits

rPa9cd14674503: Filter archived packages out of the "controlling packages" query earlier

Summary

Ref T12319. Currently, we end up filtering archived packages out once for each path. This shows up on a profile from an install as meaningfully expensive:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-7kmpevyr22aih4s2vyln/?symbol=PhabricatorOwnersPackage::isArchived

Instead, filter them out before we do any work.

Test Plan

Viewed a revision, still saw packages.

Screen Shot 2017-02-27 at 12.08.44 PM.png (602×2 px, 126 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 27 2017, 8:11 PM

Harbormaster completed remote builds in B15807: Diff 41906.Feb 27 2017, 8:12 PM

chad accepted this revision.Feb 27 2017, 8:20 PM

This revision is now accepted and ready to land.Feb 27 2017, 8:20 PM

Closed by commit rPa9cd14674503: Filter archived packages out of the "controlling packages" query earlier (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2017, 8:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

query/

PhabricatorOwnersPackageQuery.php

18 lines

Diff 41907

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Filter archived packages out of the "controlling packages" query earlierClosedPublicActions