Page MenuHomePhabricator

Filter archived packages out of the "controlling packages" query earlier
ClosedPublic

Authored by epriestley on Feb 27 2017, 8:11 PM.
Tags
None
Referenced Files
F22555560: D17427.id41907.diff
Wed, Sep 23, 12:57 PM
Unknown Object (File)
Aug 29 2026, 3:25 PM
Unknown Object (File)
Jul 3 2026, 6:12 AM
Unknown Object (File)
Jun 25 2026, 10:57 AM
Unknown Object (File)
Jun 25 2026, 10:57 AM
Unknown Object (File)
Jun 25 2026, 10:57 AM
Unknown Object (File)
Jun 25 2026, 10:57 AM
Unknown Object (File)
Jun 23 2026, 2:03 AM
Subscribers
None

Details

Summary

Ref T12319. Currently, we end up filtering archived packages out once for each path. This shows up on a profile from an install as meaningfully expensive:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-7kmpevyr22aih4s2vyln/?symbol=PhabricatorOwnersPackage::isArchived

Instead, filter them out before we do any work.

Test Plan

Viewed a revision, still saw packages.

Screen Shot 2017-02-27 at 12.08.44 PM.png (602×2 px, 126 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable