Page MenuHomePhabricator

When computing revision ownership, cache some intermediate results for performance
ClosedPublic

Authored by epriestley on Feb 27 2017, 4:05 PM.
Tags
None
Referenced Files
F21164511: D17424.id41899.diff
Fri, Jul 3, 11:19 PM
F21150575: D17424.diff
Fri, Jul 3, 4:47 PM
Unknown Object (File)
Tue, Jun 30, 11:01 AM
Unknown Object (File)
Sun, Jun 28, 12:03 AM
Unknown Object (File)
Mon, Jun 22, 1:26 AM
Unknown Object (File)
Mar 10 2026, 10:30 AM
Unknown Object (File)
Mar 10 2026, 10:08 AM
Unknown Object (File)
Mar 2 2026, 1:34 PM
Subscribers
None

Details

Summary

Ref T12319. With large datasets, the computation of which packages own paths in a revision is needlessly slow.

Improve performance through caching:

  • Cache which paths belong to each repository.
  • Cache the split fragments of each path.
  • Cache the path fragment counts.
  • Micro-optimize accessing $this->path.
Test Plan
  • Used bin/lipsum to generate 4,000 packages with 150,000 paths.
  • Created a revision affecting 100 paths in phabricator/ (these paths mostly overlap with bin/lipsum path rules, since Lipsum uses Phabricator-like rules to generate paths).
  • Before optimizations, this revision spent about 5.5 seconds computing paths.
  • After optimizations, it spends about 275ms.

Screen Shot 2017-02-27 at 8.01.39 AM.png (1×2 px, 375 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable