Page MenuHomePhabricator

Make `bin/lipsum generate` hanldle generator keys and arguments more clearly
ClosedPublic

Authored by epriestley on Feb 27 2017, 12:20 PM.
Tags
None
Referenced Files
F18818592: D17420.diff
Wed, Oct 22, 1:13 AM
F18754646: D17420.diff
Sun, Oct 5, 12:14 AM
F18704834: D17420.id41889.diff
Sun, Sep 28, 9:01 AM
F18630466: D17420.id41895.diff
Sep 16 2025, 11:43 AM
F18619357: D17420.diff
Sep 15 2025, 2:19 AM
F18508569: D17420.id.diff
Sep 5 2025, 2:54 AM
F18500643: D17420.diff
Sep 4 2025, 9:13 PM
F18487190: D17420.diff
Sep 3 2025, 7:20 PM
Subscribers
None

Details

Summary

Ref T12319. Currently, bin/lipsum uses substring matches against human-readable text to chose which objects to generate.

Instead:

  • Use separate selector keys which are guaranteed to be unique.
  • When a match is exact, select only that generator.
  • When a match is ambiguous, fail and warn the user.
Test Plan

Generated several types of objects, tried to generate ambiguous objects like "e".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable