Page MenuHomePhabricator

Make `bin/lipsum generate` hanldle generator keys and arguments more clearly
ClosedPublic

Authored by epriestley on Feb 27 2017, 12:20 PM.
Tags
None
Referenced Files
F19038462: D17420.diff
Wed, Nov 26, 4:14 AM
F18957113: D17420.diff
Wed, Nov 12, 11:20 PM
F18902348: D17420.id41895.diff
Sat, Nov 8, 12:48 AM
F18843162: D17420.id41895.diff
Tue, Oct 28, 9:06 PM
F18843161: D17420.id41889.diff
Tue, Oct 28, 9:06 PM
F18843159: D17420.id.diff
Tue, Oct 28, 9:06 PM
F18842094: D17420.diff
Tue, Oct 28, 1:14 PM
F18818592: D17420.diff
Oct 22 2025, 1:13 AM
Subscribers
None

Details

Summary

Ref T12319. Currently, bin/lipsum uses substring matches against human-readable text to chose which objects to generate.

Instead:

  • Use separate selector keys which are guaranteed to be unique.
  • When a match is exact, select only that generator.
  • When a match is ambiguous, fail and warn the user.
Test Plan

Generated several types of objects, tried to generate ambiguous objects like "e".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable