Page MenuHomePhabricator

Surface unit test results in diff
Closed, InvalidPublic

Description

I couldn't find a relevant task for this, but as a feature request it'd be nice to integrate test results (currently linked to buildables it seems) more visibly in a diff. Right now it's hidden behind "Build Status" and we rely on the Jenkins/Phabricator plugin to leave comments, which can get noisy and isn't as pretty.

Event Timeline

joshma renamed this task from Surface unit tests in diff to Surface unit test results in diff.May 2 2016, 11:21 PM
joshma created this task.
epriestley added a subscriber: epriestley.

This is supported, just not by the plugin you're using (which we don't maintain). Here's an example:

Screen Shot 2016-05-02 at 4.27.10 PM.png (838×1 px, 143 KB)

See live here:

https://secure.phabricator.com/D15814?vs=on&id=38095&whitespace=ignore-most#toc

See:

https://secure.phabricator.com/conduit/method/harbormaster.sendmessage/

See also T9456.

Oh wow, that is nice haha. I will follow up with the plugin author instead, thanks.

Just to wrap this up - the phabricator plugin for jenkins does actually report it correctly. The unit tests in our diffs don't show up unless tests are failing, so as a minor request it'd be nice to show *something* (maybe just test summary - # tests, time it took) even if all tests are passing.

You can click the buildable to get a positive summary (see B12021, e.g.):

Screen Shot 2016-05-03 at 9.29.22 AM.png (1×1 px, 225 KB)

Feedback on the revision UI has generally pulled in the vein of it being too complicated and having too many unnecessary elements for most users (see T10628, for example), so I don't foresee pursuing bringing this information to the UI by default.

You could conceivably write a listener in the vein of HarbormasterUIEventListener that runs similar logic and then emits a "yep, that passing build ran some tests" sort of confirmation message.