Diffusion Phabricator 5a4ecc7a9c5b

Convert "Diff Details" tabs to PHUITabGroup
5a4ecc7a9c5b
Actions

Description

Convert "Diff Details" tabs to PHUITabGroup

Summary:
Ref T10628. Switch this to be nicer and more modern.

When there's only one tab, add an option to hide it.

Test Plan:

Viewed normal revisions (no tabs).
Viewed X vs Y revisions (two tabs, rightmost tab selected by default).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10628

Differential Revision: https://secure.phabricator.com/D16206

Details

Provenance

epriestley	Authored on Jun 30 2016, 11:08 PM
epriestley	Pushed on Jul 1 2016, 1:49 AM

Reviewer

chad

Differential Revision

D16206: Convert "Diff Details" tabs to PHUITabGroup

Parents

rP189910d6157c: Make TabGroups a standalone UI element

Branches

Unknown

Tags

Unknown

Tasks

T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential

Build Status

Buildable 12866
Build 16404: Run Core Tests

Event Timeline

epriestley committed rP5a4ecc7a9c5b: Convert "Diff Details" tabs to PHUITabGroup (authored by epriestley).Jul 1 2016, 1:49 AM

epriestley added a task: T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.

Harbormaster completed building B12866: rP5a4ecc7a9c5b: Convert "Diff Details" tabs to PHUITabGroup.Jul 1 2016, 1:51 AM

Changes (2)

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

view/

phui/

PHUITabGroupView.php

rP5a4ecc7a9c5b

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php