Page MenuHomePhabricator

Convert all remaining old tabs to new PHUITabGroupViews
ClosedPublic

Authored by epriestley on Jun 30 2016, 11:44 PM.

Details

Summary

Ref T10628. This moves everything else over. I'll clean up the cruft in the next diff.

Test Plan
  • Viewed Conduit API page, toggled tabs.
  • Viewed Harbormaster build, toggled tabs.
  • Viewed a Drydock lease, swapped tabs.
  • Viewed a Drydock resource, swapped tabs.
  • Viewed mail, swapped tabs.
  • Grepped for addPropertyList(...), looked for any remaining calls with a second argument.
  • Also checked rSAAS for any calls, but we don't have anything there that uses tabs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Convert all remaining old tabs to new PHUITabGroupViews.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Fix one more callsite that I missed, in UIExamples.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 12:50 AM
This revision was automatically updated to reflect the committed changes.