Page MenuHomePhabricator

Make TabGroups a standalone UI element
ClosedPublic

Authored by epriestley on Jun 30 2016, 11:01 PM.
Tags
None
Referenced Files
F14058351: D16205.diff
Sun, Nov 17, 11:12 AM
F14007393: D16205.id38981.diff
Tue, Oct 29, 4:58 AM
F13976212: D16205.id.diff
Oct 18 2024, 1:17 PM
F13972660: D16205.id38980.diff
Oct 17 2024, 8:21 PM
F13968066: D16205.diff
Oct 16 2024, 6:19 PM
F13965506: D16205.id38981.diff
Oct 16 2024, 2:29 AM
Unknown Object (File)
Sep 15 2024, 7:51 AM
Unknown Object (File)
Sep 15 2024, 7:51 AM
Subscribers
None

Details

Summary

Ref T10628. Currently, tabs are part of ObjectBoxes. However, the code is a bit of a mess and I want to use them in some other contexts, notably the "prose diff" dialog to show "old raw, new raw, diff".

Pull them out, and update Files to use the new stuff. My plan is:

  • Update all callsites to this stuff.
  • Remove the builtin-in ObjectBox integration to simplify ObjectBox a bit.
  • Move forward with T10628.

This is pretty straightforward. A couple of the sigils are a little weird, but I'll update the JS later. For now, the same JS can drive both old and new tabs.

Test Plan

Viewed files, everything was unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38981.
epriestley retitled this revision from to Make TabGroups a standalone UI element.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Slight simplification: require keys to be assigned. This opens up more features later.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 12:47 AM
This revision was automatically updated to reflect the committed changes.