Page MenuHomePhabricator

Remove a parameter
ClosedPublic

Authored by sowedance on Mar 6 2014, 11:51 PM.
Tags
None
Referenced Files
F15415717: D8432.diff
Thu, Mar 20, 7:39 AM
F15405340: D8432.diff
Tue, Mar 18, 11:11 AM
Unknown Object (File)
Feb 22 2025, 7:44 PM
Unknown Object (File)
Feb 14 2025, 10:39 PM
Unknown Object (File)
Feb 9 2025, 11:47 AM
Unknown Object (File)
Feb 9 2025, 11:47 AM
Unknown Object (File)
Feb 9 2025, 11:47 AM
Unknown Object (File)
Feb 9 2025, 11:47 AM

Details

Summary

D7271 added this line but the signature of function ArcanistWorkingCopyIdentity::newFromRootAndConfigFile(...) was never changed. I have no idea why it was added here and it's causing failures in facebook. I am just removing it now.

Test Plan

No idea how to test

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2014, 11:52 PM