Remove a parameter
ClosedPublic
Actions

Authored by • sowedance on Mar 6 2014, 11:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 23, 7:39 AM

	Unknown Object (File)
	Tue, Dec 17, 10:45 PM

	Unknown Object (File)
	Dec 5 2024, 2:04 AM

	Unknown Object (File)
	Dec 1 2024, 9:21 AM

	Unknown Object (File)
	Nov 26 2024, 4:22 PM

	Unknown Object (File)
	Nov 25 2024, 2:38 PM

	Unknown Object (File)
	Nov 14 2024, 6:16 PM

	Unknown Object (File)
	Nov 6 2024, 2:52 PM

Subscribers

Details

Reviewers

wez
epriestley
lifeihuang
JoelB

Group Reviewers

Blessed Reviewers

Commits

rARC18251a1bd8b8: Remove a parameter

Summary

D7271 added this line but the signature of function ArcanistWorkingCopyIdentity::newFromRootAndConfigFile(...) was never changed. I have no idea why it was added here and it's causing failures in facebook. I am just removing it now.

Test Plan

No idea how to test

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley accepted this revision.Mar 6 2014, 11:52 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 6 2014, 11:52 PM

Closed by commit rARC18251a1bd8b8 (authored by @sowedance, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistSvnHookPreCommitWorkflow.php

1 line

Diff 20016

View Options

src/workflow/ArcanistSvnHookPreCommitWorkflow.php

Remove a parameterClosedPublicActions