Remove a parameter
ClosedPublic
Actions

Authored by • sowedance on Mar 6 2014, 11:51 PM.

Tags

None

Referenced Files

	F18855916: D8432.id.diff
	Sat, Nov 1, 7:18 AM

	F18855020: D8432.diff
	Sat, Nov 1, 2:19 AM

	F18855019: D8432.diff
	Sat, Nov 1, 2:18 AM

	F18852990: D8432.diff
	Fri, Oct 31, 1:29 PM

	F18838994: D8432.id.diff
	Mon, Oct 27, 1:52 PM

	F18772604: D8432.diff
	Oct 9 2025, 3:17 AM

	F18734659: D8432.id.diff
	Sep 30 2025, 10:59 PM

	F18432977: D8432.id.diff
	Aug 31 2025, 7:14 AM

Subscribers

Details

Reviewers

wez
epriestley
lifeihuang
JoelB

Group Reviewers

Blessed Reviewers

Commits

rARC18251a1bd8b8: Remove a parameter

Summary

D7271 added this line but the signature of function ArcanistWorkingCopyIdentity::newFromRootAndConfigFile(...) was never changed. I have no idea why it was added here and it's causing failures in facebook. I am just removing it now.

Test Plan

No idea how to test

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley accepted this revision.Mar 6 2014, 11:52 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 6 2014, 11:52 PM

Closed by commit rARC18251a1bd8b8 (authored by @sowedance, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistSvnHookPreCommitWorkflow.php

1 line

Diff 20016

View Options

src/workflow/ArcanistSvnHookPreCommitWorkflow.php

Remove a parameterClosedPublicActions