Lingers on from D7271; Rename ArcanistWorkingCopyIdentity.getConfig().
Changed all linters (Except one) to use getConfigFromAnySource(), because it seems to make sense.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC0d212ccf5a7a: rename getConfig -> getProjectConfig, make all linters use…
arc unit --everything; arc lint in github.com:epriestley/arclint-examples.git (Except for phpcs, flake8, cpplint and csslint which I don't have installed).
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I've kept ArcanistXHPASTLinter as getProjectConfig(), because it's doing some complex there.
Other places (Non linters) I've kept as getProjectConfig() because they all make at list some kind of reference to the call being project-specific.
| src/workingcopyidentity/ArcanistWorkingCopyIdentity.php | ||
|---|---|---|
| 157–161 | After last week event with ...WhateverSourceAvailable, I think this might be less harmful. | |
Comment Actions
(And I agree that all those project vs global calls are reasonable ones, to my knowledge.)
Comment Actions
Oh, I don't know if it's necessary - that usage is doing some stuff I didn't really understand and I was afraid to break it.