Page MenuHomePhabricator
Differential D7377

Provide ConfigurationManager to LintEngine in Arcanist
ClosedPublic
Actions

Authored by epriestley on Oct 21 2013, 10:27 PM.
Tags
None
Referenced Files
F18857400: D7377.id.diff
Sat, Nov 1, 3:03 PM
F18853672: D7377.diff
Fri, Oct 31, 6:40 PM
F18734488: D7377.id.diff
Sep 30 2025, 10:55 PM
F18671955: D7377.id16600.diff
Sep 25 2025, 6:03 AM
F18609665: D7377.diff
Sep 14 2025, 3:43 AM
F18421937: D7377.diff
Aug 30 2025, 5:32 PM
F18106786: D7377.diff
Aug 10 2025, 11:22 PM
F18080447: D7377.id16602.diff
Aug 4 2025, 9:50 PM
View All Files
Subscribers
aran
csilvers

Details

Reviewers
btrahan
Commits
rARCddbc14ade196: Provide ConfigurationManager to LintEngine in Arcanist
Summary

Unbreaks ArcanistSingleLintEngine / ArcanistScriptAndRegexLinter from recent config churn.

Test Plan

arc lint --engine ArcanistSingleLintEngine --rev HEAD^

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

csilvers added a comment.Oct 21 2013, 10:33 PM

Looks good to me!, fwiw. Any commit that gets rid of a todo is good by my book (whether or not it actually fixes the thing the todo was about...)

btrahan accepted this revision.Oct 21 2013, 11:55 PM

Just revisited the configuration manager on another diff. <3 it

src/lint/engine/ArcanistLintEngine.php
73

this thing is cool.

epriestley closed this revision.Oct 21 2013, 11:58 PM

Closed by commit rARCddbc14ade196 (authored by @epriestley).

Revision Contents
Changeset List

Diff 16602

View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
View Options

src/lint/engine/ArcanistSingleLintEngine.php

Loading...
View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility