Page MenuHomePhabricator
Differential D8492

Lint engine seems to get null configuration manager in svn precommit hook workflow
ClosedPublic
Actions

Authored by • sowedance on Mar 11 2014, 10:13 PM.
Tags
None
Referenced Files
F13107011: D8492.id.diff
Sat, Apr 27, 9:36 PM
F13106174: D8492.diff
Sat, Apr 27, 6:47 PM
Unknown Object (File)
Wed, Apr 24, 10:25 PM
Unknown Object (File)
Sun, Apr 21, 5:52 PM
Unknown Object (File)
Sat, Apr 20, 6:38 PM
Unknown Object (File)
Sun, Mar 31, 6:38 PM
Unknown Object (File)
Sun, Mar 31, 6:38 PM
Unknown Object (File)
Sun, Mar 31, 6:22 PM
View All Files
Subscribers
aran
epriestley
Korvin
mikemag

Details

Reviewers
epriestley
lifeihuang
JoelB
Group Reviewers
Blessed Reviewers
Commits
rARCac82dea3c9e5: Lint engine seems to get null configuration manager in svn precommit hook…
Summary

We recently tried to advance the arcanist HEAD in our release branch but failed, due to an exception in SVN pre-commit hook like this:

abort: Commit blocked by pre-commit hook (exit code 1) with output:
LINT 1.3s FacebookWebJSLintLinter (1 file)
Exception
Some linters failed:

  • FacebookWebCopyrightLinter: BadMethodCallException: Call to a member function getConfigFromAnySource() on a non-object

(Run with --trace for a full exception trace.)

However arc lint works just fine. By searching the change history, it looks related to a few commits D7271, D7377, D7382, especially D7377, where configuration manager is added to the lint engine. Add it to the SVN precommit hook workflow too.

Test Plan

I am not quite sure how to test it out easily. Any suggestions?

Diff Detail

Repository
rARC Arcanist
Branch
arc
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• sowedance updated this revision to Diff 20144.Mar 11 2014, 10:13 PM
• sowedance retitled this revision from to Lint engine seems to get null configuration manager in svn precommit hook workflow.
• sowedance updated this object.
• sowedance edited the test plan for this revision. (Show Details)
• sowedance added reviewers: epriestley, lifeihuang, JoelB.
• sowedance added a subscriber: mikemag.
Herald added a reviewer: Blessed Reviewers.Mar 11 2014, 10:13 PM
Herald added subscribers: Korvin, epriestley, aran.
epriestley accepted this revision.Mar 11 2014, 10:26 PM
epriestley edited edge metadata.

This isn't particularly easy to test. You can do something like:

svnadmin create testroot
svn checkout file:///path/to/testroot testworkingcopy

...and then install a hook, and muck around with the test working copy. But this is fairly involved. There's no reasonable way to get an SVN transaction ID otherwise, though.

This revision is now accepted and ready to land.Mar 11 2014, 10:26 PM
epriestley closed this revision.Mar 11 2014, 10:35 PM
epriestley updated this revision to Diff 20148.

Closed by commit rARCac82dea3c9e5 (authored by @sowedance, committed by @epriestley).

• sowedance added a parent revision: D8432: Remove a parameter.May 5 2014, 8:11 PM

Ignore my actions - I am just trying out the new transaction features.

Revision Contents
Changeset List

PathSize
src/
workflow/
1 line

Diff 20144

View Options

src/workflow/ArcanistSvnHookPreCommitWorkflow.php

Loading...
Phabricator · Built by Phacility