HomePhabricator

Lint engine seems to get null configuration manager in svn precommit hook…

Description

Lint engine seems to get null configuration manager in svn precommit hook workflow

Summary:
We recently tried to advance the arcanist HEAD in our release branch but failed, due to an exception in SVN pre-commit hook like this:

abort: Commit blocked by pre-commit hook (exit code 1) with output:
LINT 1.3s FacebookWebJSLintLinter (1 file)
Exception
Some linters failed:

  • FacebookWebCopyrightLinter: BadMethodCallException: Call to a member function getConfigFromAnySource() on a non-object

(Run with --trace for a full exception trace.)

However arc lint works just fine. By searching the change history, it looks related to a few commits D7271, D7377, D7382, especially D7377, where configuration manager is added to the lint engine. Add it to the SVN precommit hook workflow too.

Test Plan: I am not quite sure how to test it out easily. Any suggestions?

Reviewers: lifeihuang, JoelB, epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: aran, epriestley, mikemag, Korvin

Differential Revision: https://secure.phabricator.com/D8492

Details

Provenance
sowedanceAuthored on
epriestleyCommitted on Mar 11 2014, 10:35 PM
epriestleyPushed on Mar 11 2014, 10:35 PM
Differential Revision
D8492: Lint engine seems to get null configuration manager in svn precommit hook workflow
Parents
rARC37dac6113168: Arcanist - add revision data to TYPE_LAND_WILLPUSHREVISION event
Branches
Unknown
Tags
Unknown

Event Timeline