Differential D21035

Make "exception" on Future a private property
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 12:16 AM.

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARC6b75562c3e9b: Make "exception" on Future a private property

Summary

Depends on D21034. Ref T11968. Continue modernizing Future.

Test Plan

Ran tests, created a revision.

Diff Detail

Repository

rARC Arcanist

Branch

fx5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23926
Build 32927: Run Core Tests
Build 32926: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 27 2020, 12:16 AM

Harbormaster completed remote builds in B23926: Diff 50105.Feb 27 2020, 12:17 AM

epriestley requested review of this revision.Feb 27 2020, 12:17 AM

epriestley added a child revision: D21036: Make "FutureIterator" queue management more formal.Feb 27 2020, 2:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2020, 2:34 PM

Closed by commit rARC6b75562c3e9b: Make "exception" on Future a private property (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC6b75562c3e9b: Make "exception" on Future a private property.

Revision Contents
Changeset List

Path

Size

src/

future/

Future.php

51 lines

FutureIterator.php

67 lines

FutureProxy.php

30 lines

Diff 50105

View Options

src/future/Future.php

View Options

src/future/FutureIterator.php

View Options

src/future/FutureProxy.php

Make "exception" on Future a private propertyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50105

src/future/Future.php

src/future/FutureIterator.php

src/future/FutureProxy.php

Make "exception" on Future a private property
ClosedPublic
Actions

Revision Contents
Changeset List