Differential D20833

Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as blocks
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:04 PM.

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rP1c4450d39f9b: Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as…

Summary

Depends on D20832. Ref T13425. Emit Jupyter notebooks as diffable blocks with block keys.

No diffing or proper inlines yet.

Test Plan

Screen Shot 2019-09-25 at 12.02.00 PM.png (1×1 px, 435 KB)

Diff Detail

Repository

rP Phabricator

Branch

jupyter4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23491
Build 32283: Run Core Tests
Build 32282: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 25 2019, 7:04 PM

Harbormaster completed remote builds in B23491: Diff 49664.Sep 25 2019, 7:06 PM

epriestley requested review of this revision.Sep 25 2019, 7:06 PM

epriestley added a child revision: D20834: Correct DOM node metadata to let inline comments work against block-based diffs.Sep 25 2019, 7:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 11:32 PM

Closed by commit rP1c4450d39f9b: Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP1c4450d39f9b: Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

2 lines

render/

DifferentialChangesetOneUpRenderer.php

2 lines

DifferentialChangesetTwoUpRenderer.php

166 lines

files/

diff/

PhabricatorDocumentEngineBlock.php

20 lines

document/

PhabricatorImageDocumentEngine.php

2 lines

PhabricatorJupyterDocumentEngine.php

57 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

5 lines

phui/

phui-property-list-view.css

4 lines

Diff 49664

View Options

resources/celerity/map.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

View Options

src/applications/files/diff/PhabricatorDocumentEngineBlock.php

View Options

src/applications/files/document/PhabricatorImageDocumentEngine.php

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

View Options

webroot/rsrc/css/application/differential/changeset-view.css

View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as blocksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49664

resources/celerity/map.php

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

src/applications/files/diff/PhabricatorDocumentEngineBlock.php

src/applications/files/document/PhabricatorImageDocumentEngine.php

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

webroot/rsrc/css/application/differential/changeset-view.css

webroot/rsrc/css/phui/phui-property-list-view.css

Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as blocks
ClosedPublic
Actions

Revision Contents
Changeset List