Add a "View as..." option to diff dropdowns for selecting between document engines
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 5:49 PM.

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rP7ae711ed3e0b: Add a "View as..." option to diff dropdowns for selecting between document…

Summary

Depends on D20831. Ref T13425. As an escape hatch to get out of future DocumentEngine rendering behavior, provide a "View As.." option.

Now I can break DocumentEngine real bad and no one can complain.

Test Plan

Used "View As" to swap document engines for image files.

Diff Detail

Repository

rP Phabricator

Branch

jupyter3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/system/controller/PhabricatorSystemSelectViewAsController.php:22	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23490
Build 32281: Run Core Tests
Build 32280: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 25 2019, 5:49 PM

Harbormaster completed remote builds in B23490: Diff 49663.Sep 25 2019, 5:51 PM

epriestley requested review of this revision.Sep 25 2019, 5:51 PM

epriestley edited the summary of this revision. (Show Details)Sep 25 2019, 6:21 PM

epriestley added a task: T13425: Support diffs between abstract block lists in the UI.

epriestley added a child revision: D20833: Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as blocks.Sep 25 2019, 7:04 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 11:29 PM

Closed by commit rP7ae711ed3e0b: Add a "View as..." option to diff dropdowns for selecting between document… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7ae711ed3e0b: Add a "View as..." option to diff dropdowns for selecting between document….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

src/

__phutil_library_map__.php

applications/

differential/

parser/

DifferentialChangesetParser.php

29 lines

view/

DifferentialChangesetListView.php

1 line

system/

application/

PhabricatorSystemApplication.php

1 line

controller/

PhabricatorSystemSelectViewAsController.php

63 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangeset.js

11 lines

DiffChangesetList.js

21 lines

Diff 49663

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/view/DifferentialChangesetListView.php

View Options

src/applications/system/application/PhabricatorSystemApplication.php

View Options

src/applications/system/controller/PhabricatorSystemSelectViewAsController.php

View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Add a "View as..." option to diff dropdowns for selecting between document enginesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49663

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/view/DifferentialChangesetListView.php

src/applications/system/application/PhabricatorSystemApplication.php

src/applications/system/controller/PhabricatorSystemSelectViewAsController.php

webroot/rsrc/js/application/diff/DiffChangeset.js

webroot/rsrc/js/application/diff/DiffChangesetList.js

Add a "View as..." option to diff dropdowns for selecting between document engines
ClosedPublic
Actions

Revision Contents
Changeset List