Page MenuHomePhabricator

Allow DocumentEngine to elect into diff construction
ClosedPublic

Authored by epriestley on Sep 25 2019, 4:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 16, 3:46 PM
Unknown Object (File)
Mon, Jun 16, 11:07 AM
Unknown Object (File)
Mon, Jun 16, 9:13 AM
Unknown Object (File)
Sun, Jun 15, 6:11 AM
Unknown Object (File)
Apr 28 2025, 6:31 PM
Unknown Object (File)
Apr 20 2025, 2:36 AM
Unknown Object (File)
Apr 11 2025, 3:00 PM
Unknown Object (File)
Apr 10 2025, 8:38 AM
Subscribers
None

Details

Summary

Ref T13425. Allow DocumentEngines to claim they can produce diffs. If both sides of a change can be diffed by the same document engine and it can produce diffs, have it diff them.

This has no impact on runtime behavior because no upstream engine elects into diff generation yet.

Test Plan

Loaded some revisions, nothing broke.

Diff Detail

Repository
rP Phabricator
Branch
jupyter1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/parser/DifferentialChangesetParser.php:1697XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23488
Build 32277: Run Core Tests
Build 32276: arc lint + arc unit