Page MenuHomePhabricator

Give "Auth Messages" a view/detail state before users customize them
ClosedPublic

Authored by epriestley on Jul 19 2019, 4:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 5:34 PM
Unknown Object (File)
Sun, Mar 10, 10:08 PM
Unknown Object (File)
Feb 17 2024, 10:03 AM
Unknown Object (File)
Feb 13 2024, 12:24 AM
Unknown Object (File)
Feb 3 2024, 10:56 PM
Unknown Object (File)
Jan 24 2024, 11:24 PM
Unknown Object (File)
Dec 27 2023, 10:38 AM
Unknown Object (File)
Dec 27 2023, 12:50 AM
Subscribers
None

Details

Summary

Depends on D20663. Ref T13343. Currently, if an Auth message hasn't been customized yet, clicking the message type takes you straight to an edit screen to create a message.

If an auth message has already been customized, you go to a detail screen instead.

Since there's no detail screen on the "create for the first time" flow, we don't have anywhere to put a more detailed description or a preview of a default value.

Add a view screen that works if a message is "empty" so we can add this stuff.

(The only reason we don't already have this is that it took a little work to build; this also generally improves the consistency and predictability of this interface.)

Test Plan

Screen Shot 2019-07-19 at 9.01.17 AM.png (984×1 px, 188 KB)

Diff Detail

Repository
rP Phabricator
Branch
elogin3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23158
Build 31805: Run Core Tests
Build 31804: arc lint + arc unit