Page MenuHomePhabricator
Differential D20473

Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel
ClosedPublic
Actions

Authored by epriestley on Apr 25 2019, 5:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 11:05 AM
Unknown Object (File)
Sat, Jan 25, 4:54 AM
Unknown Object (File)
Sat, Jan 25, 4:54 AM
Unknown Object (File)
Sat, Jan 25, 4:54 AM
Unknown Object (File)
Tue, Jan 21, 7:17 PM
Unknown Object (File)
Tue, Jan 21, 3:36 PM
Unknown Object (File)
Tue, Jan 21, 10:19 AM
Unknown Object (File)
Dec 20 2024, 11:51 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13272: Remove the hard-coded homepage, and other Dashboards improvements
Summary

Depends on D20472. Ref T13272. Currently, when you edit a panel from a dashboard, we try to add the panel to the dashboard. This always works since dashboards no longer enforce panel uniqueness, and you can end up with duplicate panels.

Instead, only add panels if we're creating them.

Test Plan
  • Edited an existing panel, no duplication.
  • Created a new panel, saw it added to the dashboard.

Diff Detail

Repository
rP Phabricator
Branch
panel2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22720
Build 31142: Run Core Tests
Build 31141: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
editor/
6 lines

Diff 48845

View Options

src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php

Loading...
Phabricator · Built by Phacility