Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13279: Build Charting for Facts
- Commits
- rPedaf17f3fe51: Make chart function argument parsing modular/flexible with 900 pages of error…
Built and charted various functions with various valid and invalid argument lists, got sensible-seeming errors and results.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- chart9
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 22703 Build 31120: Run Core Tests Build 31119: arc lint + arc unit
Event Timeline
src/applications/fact/chart/PhabricatorChartFunctionArgumentParser.php | ||
---|---|---|
130 | "requesting" | |
src/applications/fact/chart/PhabricatorXChartFunction.php | ||
9 | Just for the sake of code coverage, have you tried making any functions accept more than one argument? There's a lot of fancy looping/iterating in this diff that I don't think is getting put through its paces by the existing 0/1-argument functions. |
Comment Actions
In a future diff, scale() and shift() take two arguments and work, although I'm likely rethinking exactly how the composition/chaining part of this works (see D20452 for rambling).