- This might be useful to draw a line like "goal" or "profitability".
- This might be useful to pull data from an external source.
- For composable functions like "add" or "subtract", which are useful in manipulating ETL datasets, these value functions will make testing easier.
- Maniphest Tasks
- T13279: Build Charting for Facts
- rPc4e4448ee649: Add chart functions "x()" and "constant(3)"
Added a constant(256) function:
Not sure how I feel about passing $limit here. Won't every chart function basically copy/paste the rest of the code in this function?
Also it's not obvious to me why $limit gets passed as an argument but the axis is an instance variable on this object.
This is setting the default argument to 256, right? I was looking for some reason why this to be a power of 2, maybe pick a different constant like 42?
Yeah, this changes in the ~next diff.
This is just drawing a visible line on the "demo" chart. 256 just happened to produce a reasonable line in the middle of the data on my local instance.